Topology cleanup fixes, refactor, tests#1
Merged
apendleton merged 12 commits intomainfrom Apr 20, 2026
Merged
Conversation
…r functional coverage
Collaborator
Author
|
This repo has no branch protection, watchers, or reviewers yet, so uh... YOLO |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the whole library to add an explicit set of topological fixes that take place after the main topology run. There many of these, but they correct a variety of issues with improper ring/hole assignment, bad handling of pinch-point polygons and other kinds of self-touching, etc.
Additionally, there's a new large suite of regression tests for both polygonize and nodify that capture all fixes included here.